feat: Add control plane telemetry - scheduler eligible workers histogram - #682
Open
Angela (Angelawork) wants to merge 5 commits into
Open
feat: Add control plane telemetry - scheduler eligible workers histogram#682Angela (Angelawork) wants to merge 5 commits into
Angela (Angelawork) wants to merge 5 commits into
Conversation
Angela (Angelawork)
force-pushed
the
feature/eligible-workers-telemetry
branch
from
August 4, 2026 15:52
5b29a8f to
1ff8de8
Compare
Angela (Angelawork)
marked this pull request as draft
August 4, 2026 17:51
Collaborator
|
Please rebase and fix e2e tests |
Angela (Angelawork)
force-pushed
the
feature/eligible-workers-telemetry
branch
2 times, most recently
from
August 4, 2026 18:23
2cc4a44 to
59434d7
Compare
Angela (Angelawork)
marked this pull request as ready for review
August 4, 2026 18:23
Angela (Angelawork)
force-pushed
the
feature/eligible-workers-telemetry
branch
from
August 4, 2026 18:27
ad9eac4 to
74dce74
Compare
Angela (Angelawork)
force-pushed
the
feature/eligible-workers-telemetry
branch
from
August 4, 2026 18:29
74dce74 to
8f82992
Compare
Jeff Luo (JeffLuoo)
requested changes
Aug 4, 2026
Angela (Angelawork)
force-pushed
the
feature/eligible-workers-telemetry
branch
from
August 5, 2026 21:13
e86f58b to
abf9345
Compare
Angela (Angelawork)
force-pushed
the
feature/eligible-workers-telemetry
branch
from
August 5, 2026 21:21
abf9345 to
d3eb608
Compare
Jeff Luo (JeffLuoo)
requested changes
Aug 5, 2026
|
|
||
| // RegisterEligibleWorkers registers the ate.scheduler.eligible_workers histogram instrument against meter. | ||
| // Returns (nil, nil) if meter is nil. If registration fails, an error is returned. | ||
| func RegisterEligibleWorkers(meter metric.Meter) (metric.Int64Histogram, error) { |
Collaborator
There was a problem hiding this comment.
You don't need to make RegisterEligibleWorkers a public function because it's only used in this file.
Collaborator
There was a problem hiding this comment.
Also consider using the name newEligibleWorkers because the term Register usually infer a callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #564 (Part 3)
Description
This PR implements Part 3 of #564 by adding telemetry histogram instrumentation for
ate.scheduler.eligible_workersinateapi. It measures unassigned free worker capacity remaining after all scheduling constraint filters are applied, sampled at every scheduling decision.Key Changes:
Scheduler.Schedule()to record eligible candidate workers per pool (recordEligibleWorkers).Defined
SchedulingConstraintKey(ate.scheduling.constraint) and constraint classification values (none,required_nodes,selector) ininternal/ateattr/ateattr.go.scheduling_test.gocovering candidate counts, namespaced attributes, zero-capacity fleet states, empty fleets, sandbox class mismatches, draining workers, and constraint classifications.Testing
go test -buildvcs=false ./cmd/ateapi/internal/controlapi/...go test -buildvcs=false ./cmd/atenet/internal/router/...make testE2E Test
./hack/create-kind-cluster.sh./hack/install-ate-kind.sh --deploy-ate-system --deploy-demo-counter./hack/run-e2e.sh ./internal/e2e/suites/metrics/...